commit | 94caa8b943c3b244e41cb3d5353597ba12ee938b | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Tue Feb 26 16:45:48 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 26 16:45:48 2019 |
tree | f26ca1000c1b456cab0fc341472e96e0dce1f4ff | |
parent | da8bfdcaf52ad45ffb44ea7fc5df438b7ddba1da [diff] |
Clarify which mojom namespace to use inside metrics There is both a ::mojom namespace and a ::metrics::mojom namespace so inside metrics its best to qualify which is intended or name lookup will depend on what the compiler happens to be aware of. In particular, in some jumbo builds "mojom" resolved to "::metrics::mojom" while in other builds where the compiler was unaware of ::metrics::mojom, it instead resolved to "::mojom". This is probably one of the reasons there is a style guide instruction to not have sub namespaces with the same name as a common top level namespace. Change-Id: I06545d34fac67b5f3f42fa1821eb33d381e04a41 Reviewed-on: https://chromium-review.googlesource.com/c/1485934 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#635562}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .