commit 95187d55ec74dba3dcf7885c6ac6ffab835b0f3e
author Justin Lulejian <jlulejian@chromium.org> Mon Oct 14 20:53:26 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 14 20:53:26 2024
tree 6ed382edcbe6771034c2e41b96314dc665bf96ce
parent a44f3c70b261f11a5a19389521ea2ea8437426f2

Reland "[Extensions] Create message delivery tracker class."

This is a reland of commit ce4d63c12d16f33cead60852bc256a8e5fdebed5

This reland has changes, I took advantage of the revert to make a
couple improvements and save another review commit:

1) Refactored histogram types/names. Removed some and made them
  specific to each background type. This'll make it easier to determine
  how well each background type performs.
2) Moved the class and unittest to //extensions/browser since I realized
  that when attempting to use MessageTracker it caused some circular
  dependencies
3) Added a unit test to exercise each background type.

Original change's description:
> [Extensions] Create message delivery tracker class.
>
> Message delivery appears to be failing in some stages of the message
> process because sometimes the caller never gets a response from the
> background context (specifically service workers). To scope down where
> in the process the issue might be occurring I created this class to
> help coordinate the tracking of the message.
>
> The tracker will monitor message progress through key stages and emits
> success/failure metrics. This will help pinpoint potential issues in
> the message delivery process.
>
> It allows a caller (in the browser) to call this singleton as the
> message is observed to pass through each stage.
>
> It is not specific to workers to allow for comparison between
> background types.
>
> The general flow of a call is:
>   1) NotifyStartTrackingMessageDelivery() to start tracking a message
>      to its background context
>   2) NotifyUpdateMessageDelivery() each time when the next stage in
>      message delivery has been reached
>   3) NotifyStopTrackingMessageDelivery() to stop tracking the message
>      when it has been deemed as *successfully delivered to the
>      background context (which emits success metrics)
>
> Starting and updating message delivery will result in a delayed task
> (NotifyStaleMessage()) that is called 30 seconds later. 30 seconds was
> determined arbitrarily. If the message is still being tracked at this
> point it is considered stale/unsuccessful and failure metrics will be
> emitted.
>
> *Successful can be defined differently depending on if the caller
> expects a response or not since expecting a response would track the
> later response stages back to the caller, whereas not expecting a
> response wouldn't need to track those later stages.
>
> Bug: 371011217
> Change-Id: I1d02837fb6dcccec3a56fb4cc6b1a5974087a180
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906729
> Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
> Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
> Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1366516}

Bug: 371011217
Change-Id: Icd8dd7b765c9e9a87d5b761c04aee4795c4a2393
Cq-Include-Trybots: luci.chromium.try:android-desktop-x64-compile-rel,android-desktop-14-x64-rel,android-desktop-arm64-compile-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924035
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1368420}