commit 957caecf12e36e7cb505e6ccf241d127bfcf00f3
author Matt Menke <mmenke@chromium.org> Mon Dec 12 19:47:59 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Dec 12 19:47:59 2022
tree f5c3e310f3111b869ebc643359c8185c1d0bb920
parent 73c9b3eeadaaea32505620c6cfd478eeee6f332d

[FLEDGE] Make Reporter outlive Auction.

Previously, the InterestGroupAuction owned the
InterestGroupAuctionReporter, and ran it to completion. This CL
makes to so the InterestGroupAuctionReporter is instead passed to
the AdAuctionServiceImpl, which starts the Report, then destroys
the Auction, and then runs the Reporter to completion before passing
the auction result to the caller.

This is an intermediary step towards reporting an auction result
before running the report.

This CL adds a number of warts to try and keep it simple:

* Aborting doesn't work while the Reporter is running. This will
  become (basically) moot once the Reporter runs after auction
  completion. We already only report on swap, which helps as well.

* We perform database updates updates on auction completion (Before
  reporting starts). We should do these only when a report is swapped
  in, either having the Reporter do it, or having callback passed
  to the reporter do it.

* We don't histogram the result of the reporter, and we only record
  auction result before the Reporter starts running, so if the auction
  phase completes, but the auction is cancelled before the Reporting
  phase completes, we log it as a complete auction. We should add
  logging for this.

This CL adds TODOs for the latter two of those, and the former, as
mentioned, will become moot once things are fully hooked up.


Bug: 1394777
Change-Id: I9cab9e45f3f51176aa83566dd3e6800851dc130a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4067680
Reviewed-by: Russ Hamilton <behamilton@google.com>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1081971}