commit | 6130949eaaf724cec6c90b2b54515b9e3dfe81e1 | [log] [tgz] |
---|---|---|
author | Qingsi Wang <qingsi@chromium.org> | Fri Mar 15 02:27:48 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 15 02:27:48 2019 |
tree | 154e9c7d0e89b82d77086b6ccd02e4dc129ba673 | |
parent | 609b4bbd7be1c7620c78a184a276d566f1e05a10 [diff] |
Move the getUserMedia gating of mDNS protection to FilteringNetworkManager. Our previous implementation would destroy the connection to the mDNS responder service host when the media capture permission is granted. As a result, any mDNS candidate created before the grant would become unresolvable. This issue is particularly evident when we have multiple peer connections of the same origin, where a newly created peer connection would temporarily toggle the permission to blocked before restoring the granted status if the user did give the permission. This could cause a peer connection created earlier and in the process of ICE candidate gathering to perform unnecessary mDNS obfuscation. After this change, the connection to the mDNS responder service host keeps alive, but just becomes unavailable for registration of new names when we have permissions granted. Bug: 930339, 937992 Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641046}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .