Google Git
Sign in
chromium / chromium / src / 95c3ffdd58e6c2d9c17bd81e8890f8d1806d5162
commit95c3ffdd58e6c2d9c17bd81e8890f8d1806d5162[log] [tgz]
authorRohit Bhatia <bhatiarohit@google.com>Fri Oct 21 00:18:48 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 21 00:18:48 2022
tree288dab31a8e5bb026fcd5b3ace555cb854266069
parentb30544dd1e5c1604942a1004a51ad0d0d0d2c086 [diff]
[WebProtegoAllowlistBypass] Add more histograms for debugging url checks

This CL adds these histograms

* SafeBrowsing.RT.LocalMatch.Result.(MainFrame|NonMainFrame).(Consumer|Enterprise|None)
This metric will help us understand how many allowlist checks are
happening for enterprise and for consumer real time URL checks.

* SafeBrowsing.BrowserThrottle.TotalDelay2.(ConsumerFullURLLookup|EnterpriseFullURLLookup|HashBasedCheck)
* SafeBrowsing.BrowserThrottle.TotalDelay2.EnterpriseFullURLLookup.(AllowlistChecked|AllowlistBypassed)
This metric will help us understand the impact on page load time when allowlist is
checked and when it is skipped

* SafeBrowsing.RT.ConsumerVersionReason
This metric will help us understand why the consumer version of the
real time URL check is chosen

Low-Coverage-Reason: Difficult to cover mojo impl.

Screeencast: https://screencast.googleplex.com/cast/NjU3ODIzMTM0MDY5NTU1MnxmMGUxYWQ3OC1hZg

Bug: 1376277
Bug: 1344623
Change-Id: I9f6fded7f737296ad2097c7581a613497e230f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3962597
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Rohit Bhatia <bhatiarohit@google.com>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061912}
25 files changed
tree: 288dab31a8e5bb026fcd5b3ace555cb854266069
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.