[Blink] Remove check on makeImageSnapshot() from CanvasResourceSB

CanvasResourceSharedBitmap::UploadSoftwareRenderingResults() currently
checks whether the SkImage returned from SkSurface::makeImageSnapshot()
is null and early-outs if so. However, this check is redundant:

* Tracing through makeImageSnapshot()'s software rendering path shows
  that the cases in which it can return null boil down to the
  SkImageInfo being not valid [1][2][3]
* However, the SkSurface here comes from here [4], which will also
  return null if the SkImageInfo (which is the same) is not valid [5][6]
* In that case, the CreateSharedBitmapProvider() call would have failed
  in the first place [7][8]

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/image/SkImage_Raster.cpp;l=192-194;drc=32583061c525182327dd4bbeb3530fdd21e32d9c;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/image/SkImage_RasterFactories.cpp;l=167-169;drc=32583061c525182327dd4bbeb3530fdd21e32d9c
[3] https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/image/SkImage_RasterFactories.cpp;drc=32583061c525182327dd4bbeb3530fdd21e32d9c;l=33
[4] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=229-235?q=canvas_resource_provider.cc&ss=chromium
[5] https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/image/SkSurface_Raster.cpp;l=187;drc=32583061c525182327dd4bbeb3530fdd21e32d9c;bpv=1;bpt=1
[6] https://source.chromium.org/chromium/chromium/src/+/main:third_party/skia/src/image/SkSurface_Raster.cpp;drc=32583061c525182327dd4bbeb3530fdd21e32d9c;l=36
[7] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=1096-1103?q=CreateSharedBitmapProv&ss=chromium
[8] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;l=246-248;drc=32583061c525182327dd4bbeb3530fdd21e32d9c?q=CreateSharedBitmapProv&ss=chromium

Bug: 379996128
Change-Id: I7d11a4e098211621570e4a8f09e0d2a2ef68ff61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6216270
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416669}
1 file changed
tree: 7d0d0d590446bac658b95916ce6f945a71b915af
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.