Google Git
Sign in
chromium / chromium / src / 95d6e3eaef581e1c0fb9dc9fb52c86453358602b
commit95d6e3eaef581e1c0fb9dc9fb52c86453358602b[log] [tgz]
authorSeokho Song <seokho@chromium.org>Tue Aug 23 23:58:54 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 23 23:58:54 2022
tree4f79812b7c82c2182fd822696ed44b8a2ed94fda
parent9f8d48b033665f8b7b4f0398ef4cab058ea87da0 [diff]
Add asin() function for CSSTrigonometrcFunctions

According to the CSS Values and Units Module Level 4 [1],
the trigonometric function should be parsed and evaluated.

This CL adds asin() function and testcases for asin().

And add parentheses to the test cases in sin-cos-tan-serialized.html.
It does not make test failure due to the consume simple block rule
in the spec [2]. However, the expression that missed closing
parenthesis is not the goal of the test suite
and could make misunderstandings.

Therefore, add the closing parentheses on the test cases.

Feature status: [3]
Intent to prototype: [4]

[1] https://www.w3.org/TR/css-values-4/#trig-funcs
[2] https://www.w3.org/TR/css-syntax-3/#consume-simple-block
[3] https://chromestatus.com/feature/5165381072191488
[4] https://groups.google.com/a/chromium.org/g/blink-dev/c/-c9p-Sq_gWg

Bug: 1190444
Change-Id: Ie000b6a7fd429d9c1bad28c29fc89104342706be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820863
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Seokho Song <seokho@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1038485}
12 files changed
tree: 4f79812b7c82c2182fd822696ed44b8a2ed94fda
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.