Google Git
Sign in
chromium / chromium / src / e73f847bc53b227cb7cf88f7f9d1ba19c3d86108
commite73f847bc53b227cb7cf88f7f9d1ba19c3d86108[log] [tgz]
authorZijie He <zijiehe@chromium.org>Thu Oct 19 01:25:08 2017
committerCommit Bot <commit-bot@chromium.org>Thu Oct 19 01:25:08 2017
treedc915c977ab2a4bec3e6486cef13fd6edb68f6da
parent1de4bccb0ea32f5c5bd82d7d48553c11f88659a3 [diff]
[Chromoting] Set min-bitrate of video channel to 0

According to SendSideBandwidthEstimation,
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc?rcl=033ea5f77140eef0c2defd4bd668de5dac9af3ea&l=392
the bitrate_bps won't be smaller than min_bitrate_configured_, i.e. the field
set by x-google-min-bitrate. This behavior is wrong or at least not what we have
expected in WebrtcTransport: when the bandwidth is fully used by video channel,
returning x-google-min-bitrate as the bitrate from OnTargetBitrateChanged() is
not expected.

I have verified this change on my machine, and it partially resolves the laggy
issue.

Bug: chromium:769391
Change-Id: I2c87a78af63b508b5f8b25b77e171c92a10c7426
Reviewed-on: https://chromium-review.googlesource.com/726312
Commit-Queue: Zijie He <zijiehe@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509960}
1 file changed
tree: dc915c977ab2a4bec3e6486cef13fd6edb68f6da
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .