Google Git
Sign in
chromium / chromium / src / 965e61326028405ee1949539ea3507e127409b6e
commit965e61326028405ee1949539ea3507e127409b6e[log] [tgz]
authorNeil Coronado <nemco@google.com>Thu Jun 02 23:25:54 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 02 23:25:54 2022
tree234daa55bac8e132f9f7270242351073d8e2a5e2
parent620042da3792c96c33444f8af3b8d40ee5da6bc1 [diff]
[TabletGTS] Fix startup NPE crash when attempting to show GTS

Fix startup NPE crash when attempting to show GTS.
-Crash occurs because mLayoutManager is null when we call
 isLayoutVisible(). This occurs on startup because we register the
 listener, a new tab is created because there are no open tabs, the
 creation of the first new tab triggers onTabModelSelected, then the NPE
 occurs.
-Speculative fix is to add null check.

(cherry picked from commit 310696412fe7e5064bab2cddd499c27fe3a7374f)

Bug: 1329651
Change-Id: Iab1f1caa7d0f928038efdf92e409860cb8d27b64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3668919
Commit-Queue: Neil Coronado <nemco@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1009205}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3687360
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Auto-Submit: Neil Coronado <nemco@google.com>
Cr-Commit-Position: refs/branch-heads/5060@{#499}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
1 file changed
tree: 234daa55bac8e132f9f7270242351073d8e2a5e2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.