Google GitGoogle Git
Sign in
chromium/chromium/src/9687a18f03e5547123975a67b2f076cea2c3b9ff
commit
9687a18f03e5547123975a67b2f076cea2c3b9ff
[log]
author
Yuichiro Hanada <yhanada@google.com>
Fri Aug 13 05:33:45 2021
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Aug 13 05:33:45 2021
tree
3513ec38b621a666f774dd3af7c5b34e2590165c
parent
77d6cb6241528cb55653af1599b7cb4e116386fc [diff]
Delay creating KeyboardUI until Profile is ready.

KeyboardControllerImpl::CreateVirtualKeyboard is called during
PreProfileInit(). Creating KeyboardUI in the method can cause unexpected
initialization of Profile before a user actually logins.
This CL delays checking the force enable/disable command line flag until
the profile is created.

Bug: 1187750
Test: '--enable-virtual-keyboard' flag works with DCHECK enabled.
Change-Id: I9ee12162292d0a9615883077ca11ccd00c014486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3093391
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#911648}
2 files changed
tree: 3513ec38b621a666f774dd3af7c5b34e2590165c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.