Remove TODO(bcwhite) from activity-tracker code since he no longer actively works on this.
Change-Id: I009922af6cc585ef4525a23330c7bc4368228e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3399144
Auto-Submit: Brian White <bcwhite@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/main@{#972143}
diff --git a/base/debug/activity_analyzer.cc b/base/debug/activity_analyzer.cc
index aa62a9a..d303409 100644
--- a/base/debug/activity_analyzer.cc
+++ b/base/debug/activity_analyzer.cc
@@ -283,7 +283,7 @@
GlobalActivityAnalyzer::ProgramLocation
GlobalActivityAnalyzer::GetProgramLocationFromAddress(uint64_t address) {
- // TODO(bcwhite): Implement this.
+ // This should be implemented but it's never been a priority.
return { 0, 0 };
}
diff --git a/base/debug/activity_analyzer_unittest.cc b/base/debug/activity_analyzer_unittest.cc
index a10fd16..603229aa 100644
--- a/base/debug/activity_analyzer_unittest.cc
+++ b/base/debug/activity_analyzer_unittest.cc
@@ -100,7 +100,7 @@
EXPECT_EQ(PlatformThread::GetName(), analyzer.GetThreadName());
}
- // TODO(bcwhite): More tests once Analyzer does more.
+ // More tests once Analyzer does more.
}
diff --git a/base/debug/activity_tracker.cc b/base/debug/activity_tracker.cc
index be2e766..d47b405 100644
--- a/base/debug/activity_tracker.cc
+++ b/base/debug/activity_tracker.cc
@@ -972,7 +972,7 @@
memcpy(&output_snapshot->last_exception, &header_->last_exception,
sizeof(Activity));
- // TODO(bcwhite): Snapshot other things here.
+ // Snapshot other things here.
// Retry if something changed during the copy. A "cst" operation ensures
// it must happen after all the above operations.
@@ -1425,7 +1425,6 @@
base::AutoLock lock(global_tracker_lock_);
if (base::Contains(known_processes_, pid)) {
- // TODO(bcwhite): Measure this in UMA.
NOTREACHED() << "Process #" << process_id
<< " was previously recorded as \"launched\""
<< " with no corresponding exit.\n"
