Google Git
Sign in
chromium / chromium / src / 96a80c0da26b792622e19727a15c25888ef28243
commit96a80c0da26b792622e19727a15c25888ef28243[log] [tgz]
authorAli Juma <ajuma@chromium.org>Wed Jul 31 15:42:27 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 31 15:42:27 2024
tree1501c759d59e8c3b98aef73f64ceb83bbb6d1620
parent6788a8e65dbcef5812a34b9cd72d9d019e555ee1 [diff]
Revert "Make the logo on VCN enrollment an accessibility element."

This reverts commit b9184f7839cb26467992ddae05f3436fac5de189.

Reason for revert: The modified EG test 
testVirtualCardEnrollmentDismissesAfterSkipPushed
is failing on official builders (inside the code specific to branded builds):
https://ci.chromium.org/ui/p/chrome/builders/ci/ios-dcheck-tests/1157/overview
https://ci.chromium.org/ui/p/chrome/builders/ci/ios-tests/2477/overview

Original change's description:
> Make the logo on VCN enrollment an accessibility element.
>
> Before this change the Google Payments logo was not announced by
> VoiceOver. Now, the image is an accessibility element with the
> accessibility label "Google Pay logo". VoiceOver announces "Google Pay
> logo. image GPay" for this logo.
>
> Screencap:
> https://drive.google.com/file/d/1N02Aectx6m5gM7aECLNa-StkYzN4TTzy/view?usp=sharing&resourcekey=0-SlgOXN0sdebKgRZEORcg4w
>
> Bug: b:355495835, 339887700
> Change-Id: Ia34313b5ba0afdc0c6ca1bb0e3e8cf1685e32007
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5746065
> Reviewed-by: Kavita Soni <kavitasoni@chromium.org>
> Commit-Queue: Slobodan Pejic <slobodan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1335034}

Bug: b:355495835, 339887700
Change-Id: Ib216604479b61c2bf51debb065fe94a7be5dd90b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5753583
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Ali Juma <ajuma@chromium.org>
Commit-Queue: Slobodan Pejic <slobodan@chromium.org>
Owners-Override: Ali Juma <ajuma@chromium.org>
Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1335471}
2 files changed
tree: 1501c759d59e8c3b98aef73f64ceb83bbb6d1620
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.