commit | 96b51a76e968dfbe195b0538b492292a29d26d39 | [log] [tgz] |
---|---|---|
author | Cici Ruan <cuicuiruan@google.com> | Sat Apr 13 18:19:23 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Apr 13 18:19:23 2024 |
tree | 1bc56d9c0bd37503bb6856850e081cc02f43998a | |
parent | 39c1a6c48beb49e6daffacd9dbe309e6c420eba1 [diff] |
arc/gio: Fix delete edit menu inexplicitly closing This CL changes how the delete edit menu saves in the controller. It needs to use UniqueWidgetPtr to save delete edit menu widget since it is self-owned and may be closed inexplicitly. Bug: b/334272844 Test: manual test Test: unit_tests --gtest_filter="*DisplayOverlayController*" Change-Id: I098e894946ebdccae6d2da24e9888a771d3369e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5451102 Commit-Queue: Cici Ruan <cuicuiruan@google.com> Reviewed-by: Prameet Shah <phshah@chromium.org> Cr-Commit-Position: refs/heads/main@{#1286995}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.