Google Git
Sign in
chromium / chromium / src / 96baa8a3eea395c3a91d8ff155adb2f60d81f800
commit96baa8a3eea395c3a91d8ff155adb2f60d81f800[log] [tgz]
authorMikel Astiz <mastiz@chromium.org>Mon Jun 17 14:30:37 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 17 14:30:37 2024
tree59b62ed3799ca6e975ca5155dce425c653bccd38
parent0e77c4a8b59b0fe8989f3748c5fe5429fbe2003d [diff]
[Android TRM] Avoid gating behind semi-deprecated ConsentLevel.SYNC

Ongoing efforts will lead to ConsentLevel.SYNC never returning true, so
a more feature-specific equivalent needs to be found.

For tab resumption, which is powered by the SESSIONS sync datatype, the
natural replacement is UserSelectableType.TABS, which the user must opt
into.

This change may have a small impact on metric
MagicStack.Clank.TabResumption.ModuleNotShownReason, because some cases
(signed-in-non-syncing) were previously (and incorrectly) reported as
"User not sign in", whereas after this patch they will get logged as
"User disabled sync" (which would benefit from a wording improvement).

Bug: 347173657
Change-Id: If5e48b0285ec8d9817a9ea66be2627fb3b0cd5dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633421
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1315825}
4 files changed
tree: 59b62ed3799ca6e975ca5155dce425c653bccd38
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.