Google Git
Sign in
chromium / chromium / src / 96d499224fbab1784f05ee170610820787ce91f5
commit96d499224fbab1784f05ee170610820787ce91f5[log] [tgz]
authorZoraiz Naeem <zoraiznaeem@chromium.org>Thu Jun 20 19:17:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 20 19:17:25 2024
treedd562546a81b461273a467e919a3402ebbeda4b4
parent19643a8d9ad81dd4985db5b5946efff8742fecc5 [diff]
Snapped rounded corner bounds of the surface to pixel boundary

Lacros specifies rounded corners bounds on the content layer to round
the window. Lacros submits un-ceiled rounded corner bounds to exo. However for certain device scale factors, we get 1px misalignments between the content and non content area.

In crrev.com/c/4726545, the rounded corner bounds were ceiled on the
client side. The change was made in cc, however, given Ash Chrome uses
the same code path, ceiling the rounded corner bounds caused 1px
mis-alignments in the ChromeOS UI. (See b/329864176)

After thorough discussion [1], and taking into account the blink
expectations, it was decided to revert crrev.com/c/4726545. To fix the
original lacros issue, we snap the rounded corner bounds to pixel
boundary in exo itself.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5606007/comments/c3506ff3_34177195

Bug: b/40267343
Change-Id: I95ad89205ea73b3fb2d335779aeb45052726bd66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5605790
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1317551}
4 files changed
tree: dd562546a81b461273a467e919a3402ebbeda4b4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.