Google Git
Sign in
chromium / chromium / src / 96db3558cd5847112cb93c39bb33bc1b8ffb511a
commit96db3558cd5847112cb93c39bb33bc1b8ffb511a[log] [tgz]
authorVasiliy Telezhnikov <vasilyt@chromium.org>Wed Nov 13 17:53:35 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 13 17:53:35 2024
treea6cd6aa08cd50962c53ca96489eb3b851c42cadf
parentaf15897547c092c1dfe84b0a4fe9f38b737873e7 [diff]
Remove flip from UnacceleratedStaticBitmapImage::CopyToResourceProvider

The only resource provider that can have bottom-left origin is
CanvasResourceProviderPassthrough, but it doesn't implement
CreateSkSurface [1] which is needed for default WritePixels
implementation [2] and it doesn't provide it's own.

In practice this code is only called from WebGPU which uses
CanvasResourceProviderSharedImage. There quite a few limitation on
what we can do with bottom-left origin images, but in unlikely event
if we need to support WritePixels to them flip should happen inside of
the implementation.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;drc=981ce1e8f82050b33153a9c4652f2ad1cefabff1;l=852

[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc;drc=61318fca180640aa6607e78d67ec4dbe2ed00bfb;l=1790

Bug: 378688985
Change-Id: I6374b3d6c59330f623d8322c7c8ee20d9b97e089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6017066
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382435}
1 file changed
tree: a6cd6aa08cd50962c53ca96489eb3b851c42cadf
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.