commit | 96e1a8203445b02423fc761778248e0f747b720e | [log] [tgz] |
---|---|---|
author | xiangdong kong <xiangdongkong@google.com> | Fri May 19 02:28:53 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 19 02:28:53 2023 |
tree | 4d637fef1d81877650c67bdb1e1000e6db76a17d | |
parent | 99e694345a9f63c0b82d08d26637d16798b12230 [diff] |
feedback: Do not create a new instant if one exists already When an instant of the new feedback app has been created, further request to open the app again should reuse the existing instant. Current behavior: - The existing instant is unloaded. - A new instant is created. This may cause the description entered get lost. - Check whether there is an instant existing already. - If yes, simply show it. - If no, launch a new instant. Bug: b:283145415 Test: 1) press ALt+Shift+I to open the feedback app. 2) Enter some text, say "testing...". 3) Click the "Tips on writing feedback" link. 4) Observe that the link is opened and its page is focused. 5) Visit About Chrome from settings, click "Send Feedback". 6) Observe that the feedback app is brought back to focused. 7) Observe that the text entered before is still there. Change-Id: I1e45e25779bcf374df7289683696bbaf0076fd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547919 Commit-Queue: Xiangdong Kong <xiangdongkong@google.com> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#1146330}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.