ime: Fix a corner case in ConfirmCompositionText where commits get lost.

Here's a corner case in handling IME operations:

1) IME calls CommitText()
2) IMF receives CommitText and enqueues the operation as pending.
   This is because we may get more operations and they could be
   coalesced together.
3) IME calls FinishComposition()
4) IMF receives FinishComposition. FinishComposition is not enqueued.
   Instead, it is immediately executed, which resets the IMF state.
   We lose the pending commit as a result.

There's a long history around why certain things get queued and some
don't, but overall the pending commit/composition logic is very
convoluted.

To fix the root cause problem, we will either remove the pending
operation logic completely, or ensure all operations are queued
consistently.

For now, fix this problem for M100 by targeting this specific
scenario of calling ConfirmCompositionText when there's a pending
commit. Since the pending commit will destroy any composition,
ConfirmCompositionText will be a no-op in this case.

Fixed: 223075193
Change-Id: I7defbee25dffe46d856bd65b39cdef4c52dcd4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3530969
Auto-Submit: Darren Shen <shend@chromium.org>
Reviewed-by: Bao-Duy Tran <tranbaoduy@chromium.org>
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982113}
1 file changed
tree: f2280bb8d0c6c237335834a47d82e06f896f5d9b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.