commit | 97adbc10d2cde13dde9d71a0475e1167498ac9af | [log] [tgz] |
---|---|---|
author | Shibalik Mohapatra <shibalik@chromium.org> | Tue Dec 19 10:57:32 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Dec 19 10:57:32 2023 |
tree | faa38c14a178ca2298197783b99a43d42447f776 | |
parent | 5630b568d0ab57ae57103aa45c4136453fb15529 [diff] |
Reland "[SidePanelPinning] Add IsSidePanelPinningEnabled() method to guard the pinning feature." This is a reland of commit 346d9f809140c0815a64c9b391e829713101bb4d Reason For Reland: This change was incorrectly reverted b/1511818 . Even after revert the same issue persisted. The change also removed the dependence of SidePanelPinning on Responsive toolbar. Original change's description: > [SidePanelPinning] Add IsSidePanelPinningEnabled() method to guard the pinning feature. > > This is so that it can be tied with responsive toolbar. Also the feature assumes refresh is enabled. > > The CL also contains fixes for recent_tabs_sub_menu_model with refresh as the menu model is different with refresh flag. > > Also parametrize browser_view unittest so there is coverage with refresh turned on and off. > > Bug: 1511039 > Change-Id: Icc413cc113469960a22e05fab2d42b677b16cc20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5120541 > Reviewed-by: Ryan Sultanem <rsult@google.com> > Reviewed-by: Caroline Rising <corising@chromium.org> > Reviewed-by: Darryl James <dljames@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1237839} Bug: 1511039 Change-Id: I8e022cd4124a61daf7334edf05cb374ce2a7105c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5132473 Reviewed-by: Caroline Rising <corising@chromium.org> Reviewed-by: Darryl James <dljames@chromium.org> Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1239022}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.