Change data pipe for capture to ReadWriteAudioDataPipe This is in preparation for an experiment to optimize capture IPC, which we expect to save a significant amount of CPU and power. go/input-ipc-optimization This changes the shared memory used for audio capture from ReadOnlySharedMemoryRegion to UnsafeSharedMemoryRegion, to allow the Renderer to write to it. The API changes are in two files: * media/mojo/mojom/audio_stream_factory.mojom * media/mojo/mojom/audio_data_pipe.mojom * media/audio/audio_input_ipc.h and the rest of the changes follow from those files. We believe this is safe because: 1) We do not trust or take any sensitive actions based on what is written in the shared memory. A rogue Renderer, or anyone else writing to the shared memory, cannot do anything dangerous by writing to it. 2) Audio playout has always used UnsafeSharedMemoryRegion, without it causing any security issues. Bug: 380422501 Change-Id: I76a83ff1134b09e83d213e7f609bbec078d4c69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038937 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com> Reviewed-by: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391519}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.