commit | 982a56943ff384c379c08f3dee506d254d334192 | [log] [tgz] |
---|---|---|
author | Andrew Xu <andrewxu@chromium.org> | Thu Jan 16 16:33:46 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 16 16:33:46 2020 |
tree | 6faac851da562568c2681d386d63eb9a60904600 | |
parent | 8630c10deb622a8fa06c5a28f25631f31970ec8f [diff] |
Make the icon's final bounds be minimization's target bounds The current minimization animation, which is triggered by going to home screen from in-app shelf, uses the bounds of the icon which corresponds to the active window to be minimized as the animation's target bounds. However, hotseat's bounds change due to entering the home screen. As a result, the target bounds are not the final bounds. This CL fixes the issue by providing an interface to calculate the icon's bounds according to the hotseat's target bounds instead of the actual bounds. There are four ways to show the home screen from in-app shelf: (1) Press the home button. (2) Gesture fling up on the hotseat. (3) Back gesture. (4) Tap on the shelf icon. In case (1), hotseat's target bounds have been set before starting the window scaling animation. In other cases, target bounds are not set yet. Thanks to https://crrev.com/c/1999443, case 3 and case 4 are solved. The last one, case 2, will be fixed in the following CL. Bug: 1030819 Change-Id: I63cafabe6527aba49e9f98e338f9f248284e1d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996268 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732416}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .