Google Git
Sign in
chromium / chromium / src / 983170a7a253fdcf92935ddddcf9f21352aef91b
commit983170a7a253fdcf92935ddddcf9f21352aef91b[log] [tgz]
authorDavid Bertoni <dbertoni@chromium.org>Mon Nov 06 15:26:13 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 06 15:26:13 2023
tree5ac6de1a2f8b0ec8f1a6c49ff96933db842aa24e
parent6093a041d1c3f2ff4e6b1aea142bb1a3658afe65 [diff]
[Code Health] Remove uses of base::SupportsWeakPtr

(/chrome/browser/sync_file_system)

This CL removes uses of this deprecated base class by adding a
base::WeakPtrFactory data member.

In some cases, the base class was no longer being used, so it's
simply removed.

In some cases, it was being used as the base class for a supposed
interface class. In those cases, a pure virtual member function
was added so that implementation classes can have a WeakPtrFactory
data member and dispense appropriate WeakPtr instances.

This CL was uploaded by git cl split.

R=asully@chromium.org

Bug: 647430
Change-Id: Ia45c8220f2976c72247df12d98cee4a8d3073586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5005606
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1220286}
3 files changed
tree: 5ac6de1a2f8b0ec8f1a6c49ff96933db842aa24e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.