Google Git
Sign in
chromium / chromium / src / 98463d098ef19a7245d88d1e5bd26bb96ee1ca83
commit98463d098ef19a7245d88d1e5bd26bb96ee1ca83[log] [tgz]
authorKenichi Ishibashi <bashi@chromium.org>Fri May 23 04:12:07 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 23 04:12:07 2025
treec40f8a9bc04a030401e50b8ff4e9c926fb25a925
parentad1f8ec51a5a765bad7d29c7f19addb489a96254 [diff]
HttpStreamPool: Update some tests

This is a preparation for making AttemptManager enter "draining"
state after all jobs are notified. Some tests assumed that:
- Could access AttemptManager via Group after notification.
- Only one FakeServiceEndpointRequest was needed.

When we make AttemptManager enter "draining" these don't always hold.
Update some of these tests to remove such assumptions. Changes are:
- Use the associated AttemptManager of a StreamRequester, which can
  be used unless the AttemptManager is destroyed.
- Use the default resolution for ServiceEndpointRequest.

No behavior changes.

Bug: 414173943
Change-Id: I550ae7455e65aa25ba8132f2b604390a7bf5efe8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6581796
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1464552}
1 file changed
tree: c40f8a9bc04a030401e50b8ff4e9c926fb25a925
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.