Explicitly wait for sad frames in two ChildFrameCrashMetrics tests. Previously, the KilledWhileVisible and KilledWhileHiddenThenShown tests relied on sad frame metrics being logged synchronously after a process kill or after a WebContents visibility. Make these tests more robust by explicitly waiting for all sad frames to be shown before checking metrics. This is an attempt to deflake these tests. Additionally, add some explicit expectations around subframe visibility on a shown/hidden a WebContents, to aid debugging in case these tests are still flaky. Bug: 1097060 Change-Id: I05567e9c76f94f32c0f2bbabf47fc2cfa2b013e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509003 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ćukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#822772}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.