commit 990b3721cdbb2092b8977cc43964b0d0ddaca046
author Colin Blundell <blundell@chromium.org> Thu Feb 06 09:08:38 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 06 09:08:38 2025
tree 08c3fe378a78e59f4ebde46cc9e1140ade2e87ee
parent e2c50320a152fd1398550f470d6389a0e131e5ca

[Blink] Change HTMLCanvasPainter test setup

The test invokes CanvasRenderingContext2D::FinalizeFrame() after first
setting up HTMLCanvasElement to have a non-null Canvas2DLayerBridge
(via the SetResourceProviderForTesting() call) to ensure that
CanvasRenderingContext2D regards the canvas as paintable and doesn't
short-circuit out. However, we will shortly be changing
CanvasRenderingContext2D::IsPaintable() to check for the presence of
the CanvasResourceProvider rather than the bridge. In preparation, this
CL changes this test's setup to create the CanvasResourceProvider rather
than just the bridge.

Note that the new test setup is more representative of a production flow
in any case:

* In production the only way for the bridge to be created is via
  an attempt to create the provider, so that must have been invoked
  before FinalizeFrame() for FinalizeFrame() to regard the canvas as
  paintable
* While it is possible for GetOrCreateCanvasResourceProvider() to
  successfully create the bridge and fail to create the provider, if
  FinalizeFrame() is called after that occurs it will also fail to
  create the provider and will short-circuit out here [1].

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=848-850?q=CanvasRenderingContext2D::FinalizeFra&ss=chromium

Bug: 40280152
Change-Id: Ic06c18246f623f4a7b8f429a6d8b1a983aa22828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6233993
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1416655}