Google Git
Sign in
chromium / chromium / src / ac5bca6a77e657d7879b6c78080da2b7b6f677bd
commitac5bca6a77e657d7879b6c78080da2b7b6f677bd[log] [tgz]
authorXi Han <hanxi@google.com>Wed Sep 28 21:13:59 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 28 21:13:59 2022
tree4d83217828715af9132d51a10016e35687654fe7
parent186874fba405e7568253b113d7755ab8ff5bb716 [diff]
[Start] Don't disable Start when user has a customized homepage URL.

This CL allows enabling Start even if user has a customized homepage URL. Things are NOT changed for OEM phones users or users with customized homepage URL:
1) Tapping home button on a Tab navigates to homepage URL; 2) tapping new tab shows NTP; 3) when launching Chrome without any tab (i.e., FRE), opens a tab which navigates to the homepage URL.

Things are changed:1) Don't recreate ChromeTabbedActivity when homepage URL changes.2) OEM phone users will see Start if they don't use chrome for 8 hours.

Demo for customized homepage phone:
https://drive.google.com/file/d/1sdC67ZXP4ieXC5XyU3bMNWZfWh0LY9df/view?usp=sharing

Bug: 1368224
Change-Id: I99f37888d834f50cc6fa91b19b7f9ba188e31c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3920210
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1052626}
6 files changed
tree: 4d83217828715af9132d51a10016e35687654fe7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.