Google Git
Sign in
chromium / chromium / src / 9950b060870677c81d1d5305120ca04ab5b97546
commit9950b060870677c81d1d5305120ca04ab5b97546[log] [tgz]
authorOrr Bernstein <orrb@google.com>Fri Aug 09 20:24:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 09 20:24:20 2024
treebf3f34b2177ae651aec06a9a3fa36a11cc52635c
parent177d0d55b850aca5d8876e45d7d877c068569027 [diff]
Fix dangling pointer crash when process is ready after auction ends.

In a previous change -
https://chromium-review.googlesource.com/c/chromium/src/+/5740146 - we
added a metric that measures the start/end time of a phase of the
Protected Audience auction in which the auction waited for worklet
creation. To correctly capture this phase, we instrumented the
AuctionWorkletManager to report when the processes backing the worklets
became available. However, because of an incorrect use of
base::Unretained, the callback indicating that the process was available
could be called after the AuctionWorkletManager had already been cleaned
up following the end of the auction. This change replaces the
base::Unretained with a weak pointer provided by the existing
weak_ptr_factory_.

Bug: 348443991
Fixed: 357555097
Change-Id: Ic8b7d296b42cdeffd0412220c5b47b8e0f13dd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5762309
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Orr Bernstein <orrb@google.com>
Cr-Commit-Position: refs/heads/main@{#1339837}
2 files changed
tree: bf3f34b2177ae651aec06a9a3fa36a11cc52635c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.