commit | 995e7b9aba32b194962d98b0bf44e8fe03d4011e | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Mon May 17 11:17:16 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 17 11:17:16 2021 |
tree | f26cd9ab3687069583be397201db26e0d4a56b05 | |
parent | 1370872c5cf22bcd92b85324ada409e75780fe12 [diff] |
[Android] Fix trying to remove out-of-bounds autofill suggestion If the suggestions known to the popup controller change but a removal confirmation is still pending, the index held by the confirmation is out of date and can either: * delete an incorrect suggestions or * cause a crash due to an out-of-bounds access. This CL only fixes the latter case but might need to be merged. A proper fix would involve wide-spread changes to the identification of a selected suggestions (see https://crbug.com/1209792). Bug: 1208721 Change-Id: Ib5d352b1752583faf01aa28ef61c983f0c655921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896977 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#883425}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.