commit | 9976c412df4971da163ba3fd40b895227c05448f | [log] [tgz] |
---|---|---|
author | Jesse McKenna <jessemckenna@google.com> | Tue Sep 26 18:52:17 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 26 18:52:17 2023 |
tree | efd689860bbbabe4bf550cb417a3caa3610e86cb | |
parent | 62e8ee9fd72dd73ba6718c33a5cb40b36383d2ed [diff] |
Revert "breadcrumbs: graduate from field trial" This reverts commit 3f8982fef685ebd703a422c313bcda072ea77cc6. Reason for revert: Hits a DumpWithoutCrashing on Android, so the local prefs need to be retrieved a different way on that platform. Original change's description: > breadcrumbs: graduate from field trial > > This change enables breadcrumbs crash logging client-side rather than > via field trial. > > Currently, breadcrumbs is enabled on 5% of Stable and 50% of > pre-Stable channels via field trial. It will be kept at 5% of Stable > indefinitely and considered "launched", as there's no need to collect > breadcrumbs on every client (5% is expected to be enough). > Specifically, this CL will enable breadcrumbs on: > * 99% of Canary > * 80% of Dev and Beta > * 5% of Stable > > Because field trial is not intended to be used indefinitely, this > change uses a simple random function to decide whether to log > breadcrumbs. Breadcrumbs will stay enabled or disabled for a month > before re-rolling, so the same users don't always incur the overhead > of logging (which is relatively small, but still). > > This follows the guidance at go/graduating-from-finch and takes > inspiration from existing code in SwReporterInstallerPolicy > (https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/component_updater/sw_reporter_installer_win.cc;l=346;drc=6693230146e9f1f3317bf973d5d82a083369a0fa). > > Change-Id: Ibf0d95558f45285b463733c67cbe1851f4f70ed2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4585086 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Dominic Battre <battre@chromium.org> > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1200270} Change-Id: Ic0262cb726961e0fedc8d205c7fcbe55d7d2cda3 Bug: 1486295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4892132 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/main@{#1201706}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.