commit | 99be7d703496e7131474b4c5f9620024ade513d0 | [log] [tgz] |
---|---|---|
author | Kurt Catti-Schmidt (SCHMIDT) <kschmi@microsoft.com> | Tue May 25 22:32:17 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 25 22:32:17 2021 |
tree | 6ca087c23ce7c0561a687a8f73046bb27b02fcae | |
parent | d0ba805fc99b19daa6278b1fdafab192403dc9f9 [diff] |
[GridNG] Updating grid-baseline-align-cycles-001.html This CL updates this test to match expectations where baseline alignment should not apply. The CSS Grid spec indicates that baseline alignment should not apply in cases where there's a cyclic dependency on sizing in the dimension where baseline alignment applies. However, it also states that certain conditions will force another sizing pass, and under such conditions baseline alignment may be possible, and under these circumstances, baseline alignment should apply. If we were to change behavior to match this test case, numerous other second pass baseline tests would break. In fact, this test was actually matching the old expected results before we added logic to support second passes on baseline alignment - see https://chromium-review.googlesource.com/c/chromium/src/+/2873217. Instead, this change updates the test expectations so that they are all situations where baseline alignment should never apply. Bug: 941987 Change-Id: Icec9ec1a2708f488dd2dd0d6c472859b36fb2460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911306 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#886493}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.