commit | 9a403b83cd44ce90c629a2f72d89605e658bfab4 | [log] [tgz] |
---|---|---|
author | Xiaochen Zhou <xiaochenzh@chromium.org> | Mon Mar 31 16:39:46 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 31 16:39:46 2025 |
tree | 9823c29c717345df65cb74e0ad311cded32f4287 | |
parent | 78db3624dbc760152bfb62ed0f80cdaaa5c5e8a9 [diff] |
Reland "Fenced frames: Add WPT for verifying network status recalculation with respect to ongoing navigation changes." Mark long timeout. The tests are failing because in CI tests, the try bot is using a smaller timeout limit(6000ms). While in CQ, the try bot uses 12000ms as timeout limit. So it passes the CQ but fails in CI, which only runs after submission. However, here dry run with "Include-Ci-Only-Tests:" footer does not set try bot's timeout limit to 6000ms. It still uses 12000ms. So without marking timeout as long, test will still pass. But I think this confirms that the timeout is the issue here. This is a reland of commit 2c55f3b1b80827ba128fb60ae9429da1a2acac4b Original change's description: > Fenced frames: Add WPT for verifying network status recalculation with > respect to ongoing navigation changes. > > Add a WPT that sets up a fenced frame with a nested iframe. The nested > iframe initiates a navigation to a URL that hangs, and after a while it > starts another navigation that receives a 204 response code. The fenced > frame attempts to revoke untrusted network right after the first > navigation starts. The promise returned by `disableUntrustedNetwork()` > will not resolve until the second navigation completes. > > This is to verify the recalculation takes place even if the navigation > does not commit (204). As long as ongoing navigation concludes, the > recalculation should be triggered. > > Note if the nested frame is a fenced frame, after the navigation > receives 204 response, the promise at parent FF should not resolve. > This is because it is required to have all descendant fenced frames to > revoke network before the parent fenced frame disable untrusted network > promise can resolve. A test is added to: > disable-untrusted-network.https.html > > See: https://github.com/WICG/fenced-frame/pull/215#issuecomment-2749129974 > > Bug: 397377177 > Change-Id: Ic317580754366c2f55ff34639da875a8afee7b2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6394457 > Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> > Reviewed-by: Liam Brady <lbrady@google.com> > Cr-Commit-Position: refs/heads/main@{#1439477} Bug: 397377177 Change-Id: Icf551fd5ac626ebcd08547cd4ba785a0e95fe2cb Include-Ci-Only-Tests: *|blink_wpt_tests Cq-Include-Trybots: luci.chromium.try:mac13-arm64-rel,mac14-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6409013 Reviewed-by: Liam Brady <lbrady@google.com> Commit-Queue: Liam Brady <lbrady@google.com> Cr-Commit-Position: refs/heads/main@{#1440321}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.