Google Git
Sign in
chromium / chromium / src / 9a6e239e39794e390d28a047ec7bd6b74c3292d0
commit9a6e239e39794e390d28a047ec7bd6b74c3292d0[log] [tgz]
authorKevin McNee <mcnee@chromium.org>Fri Jul 16 20:03:10 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 16 20:03:10 2021
tree058803553504b2cec83ad1101b6ff9aaa180b333
parentc78c04435d59ac8e77ae5bc6a2071a7a7cbc5a67 [diff]
Replace several FrameTreeNode id based lookups with RFH ids

These subresource filter and ad metrics callers of
UnsafeFindFrameByFrameTreeNodeId can be refactored to not use this
method.

There are several cases of going from a FTN id to a RenderFrameHost,
then back to the FTN id, where the lookup can simply be removed.

For cases that do need a RenderFrameHost, the call sites can identify
the intended RenderFrameHost more directly using
NavigationHandle::GetPreviousRenderFrameHostId.

Bug: 843646, 1184484
Change-Id: I28c0476f4961256d9a4db4eb5d55f730d9e676f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2736836
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#902609}
6 files changed
tree: 058803553504b2cec83ad1101b6ff9aaa180b333
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.