| commit | 9a951ba73e71b9a5624f242f2d06db0edcdceb1c | [log] [tgz] |
|---|---|---|
| author | Masayuki Fujita <massan@google.com> | Mon Sep 04 01:25:40 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 04 01:25:40 2023 |
| tree | 1304f91b2c07cea741b7396a4d1f1f97cdd1ce0e | |
| parent | 2cf658602019084d84f76ae21f26371fb4536ffa [diff] |
pip-pinch: Reuse component value during gesture transitions This commit makes sure that the `window_component` is set properly with gesture transitions when the first gesture is started by the client. The pinch-to-resize feature handles gesture transitions (i.e. drag to pinch and vice versa). The same `window_component` should be used from when the first finger touches the screen to when the last finger leaves the screen. Usually when a gesture is started by the client, the client specifies the window_component to be used for the rest of the gesture. However, when a gesture is not initiated but instead is transitioned from another, new gestures were initiated by `ToplevelWindowHandler` using the incorrect `window_component`. To fix this, `ToplevelWindowEventHandler` now keeps track of the first gesture’s `window_component` and it’s now reused until all of the gestures end. Bug: b/295972987 Change-Id: I1913bf3dad90ba1801b4c97120e7db65571673e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4824529 Reviewed-by: Kazuki Takise <takise@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Auto-Submit: Masa Fujita <massan@google.com> Commit-Queue: Masa Fujita <massan@google.com> Cr-Commit-Position: refs/heads/main@{#1191894}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.