pip-pinch: Reuse component value during gesture transitions

This commit makes sure that the `window_component` is set properly with
gesture transitions when the first gesture is started by the client.
The pinch-to-resize feature handles gesture transitions (i.e. drag to
pinch and vice versa).  The same `window_component` should be used from
when the first finger touches the screen to when the last finger leaves
the screen. Usually when a gesture is started by the client, the client
specifies the window_component to be used for the rest of the gesture.
However, when a gesture is not initiated but instead is transitioned
from another, new gestures were initiated by `ToplevelWindowHandler`
using the incorrect `window_component`.

To fix this, `ToplevelWindowEventHandler` now keeps track of the first
gesture’s `window_component` and it’s now reused until all of the
gestures end.

Bug: b/295972987
Change-Id: I1913bf3dad90ba1801b4c97120e7db65571673e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4824529
Reviewed-by: Kazuki Takise <takise@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Auto-Submit: Masa Fujita <massan@google.com>
Commit-Queue: Masa Fujita <massan@google.com>
Cr-Commit-Position: refs/heads/main@{#1191894}
1 file changed
tree: 1304f91b2c07cea741b7396a4d1f1f97cdd1ce0e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.