commit | 9ac61227457752b101dde55b208212414144ad98 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Thu Sep 21 15:29:24 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Sep 21 15:29:24 2017 |
tree | cefac3e8ed1c39ff3d485b30d7ff57a093b3732b | |
parent | 66fa8c6e7ead7dedeed5b87e2587bb3896f8e66d [diff] |
Make sure to include traits before testing them in tests. It's possible to check traits without including their specialization or doing an implicit instantiation but then you get the default values which can be wrong (or you would not have had a specialization). In jumbo builds this is noted because first you get an implicit instantiation and then an explicit instantiation which is a C++ error. Fix is to make the explicit instantiation before any implicit instantiations can happen. I do wish this error wasn't so invisible. It's the third or fourth detected through jumbo builds. Bug: 761475 Change-Id: Ifceb604e027ac8877764b584555007c854c74f03 Reviewed-on: https://chromium-review.googlesource.com/677383 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#503454}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .