| commit | 9ad521a7c2eeb187140811147da00ca8a9922565 | [log] [tgz] |
|---|---|---|
| author | Daniel Cheng <dcheng@chromium.org> | Wed Sep 18 00:21:56 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 18 00:21:56 2024 |
| tree | a301914e30a160ebc44b9b352aaadcf75356258c | |
| parent | 6740069c47d719d503e37e272a941ef38a0972b8 [diff] |
Follow map best practices in DownloadFileImpl implementation
- Use insert({key, value}) instead of operator[] for insertions
- Avoid repeated lookups for the same key
- Strengthen a DCHECK() to a CHECK(), since failing the DCHECK() means
potential memory safety issues.
Change-Id: I54fbb83895b3d22ad2753108ac6c02fd7d4724be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5858474
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1356832}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.