commit | 9ba8e2cb805e0d6fcb0d7a963ee39cfff2559548 | [log] [tgz] |
---|---|---|
author | Mehrab N <mehrab@chromium.org> | Wed Jun 01 22:31:55 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 01 22:31:55 2022 |
tree | be7de15e0bb7c0ecde22e67c0fd48d17c610145a | |
parent | a35c41a56b7308f7be6ae5c2c08254531b030f2d [diff] |
emoji-picker: remove emoji-button from emoji-group EmojiButtons are now removed from emoji-group and their related functionalities are directly implemented in emoji-group. Considering the large number of emojis created by each instance of emoji-group component, the CL helps optimizations such as centralizing common functionalities (e.g. event handling, sharing tooltip component) and reducing complexities around aligning emoji-buttons and emoji-groups (e.g. styles are dependent, dependent event handling). eliminating emoji-buttons usage in emoji-variants. Note: emoji-buttons can be removed after refactoring emoji-variants and Bug: b:233130994 Change-Id: I7752b545a91f15b3b5210fb7701f01b4f263ac06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3683058 Reviewed-by: Darren Shen <shend@chromium.org> Reviewed-by: John Palmer <jopalmer@chromium.org> Commit-Queue: Mehrab N <mehrab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009837}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.