Google Git
Sign in
chromium / chromium / src / e59f9a1bcb78898b0d5c966e7f5acd9e51df11a8
commite59f9a1bcb78898b0d5c966e7f5acd9e51df11a8[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Thu Apr 24 21:51:27 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 24 21:51:27 2025
treed07d0185367cd3fa5dc553dfce699dd6403076ef
parent10c3ba2cf972d781e5ab5e9748c24116a9d938c3 [diff]
[line-breaker] Early return when the whole item can fit

This patch adds an early return code path to
`ShapingLineBreaker` when it's obvious that the whole item
can fit. By returning early, we can skip `EnsurePositionData()`,
which is one of visible functions in the pprof.

This code path hits more often for short text, while less for
long text with little number of spans. In the Speedometer3,
it hits ~40%.

This change improves the Speedometer3 score by ~0.2%.

To mitigate risks of breaking cases not covered in the current
tests, the change is under a runtime flag.

Bug: 413315840
Change-Id: Icdb3ad9deca7a449c41d74ee0876c6533a14f045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6482970
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1451477}
2 files changed
tree: d07d0185367cd3fa5dc553dfce699dd6403076ef
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.