Google Git
Sign in
chromium / chromium / src / 9c43f9c7007f95314b4f968889bf1e7a6c7d8ea9
commit9c43f9c7007f95314b4f968889bf1e7a6c7d8ea9[log] [tgz]
authorBrittany Hartmire <bhartmire@google.com>Thu Jul 27 06:48:39 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 27 06:48:39 2023
tree68058c9be21b50d10da1a13c64446cdcd6c3f79e
parent5449ea7191296e4a382aae5cbc8a4fc4b6fbe899 [diff]
[PhoneHub] Add distinct inline reply send button accessible name

Cvox read aloud identical "reply" announcements for the reply input
textfield and reply send button. This CL adds an accessible name for
the send button and updates the button tooltip to use the same new
string, "Send reply". Having the tooltip match the accessible name
prevents cvox from reading redundant descriptions for the button.

Before: http://screencast/cast/NjA3NDEwMDQ1MjY4Nzg3MnwyNDg4MjdlOC0wYQ
After: http://screencast/cast/NjQ2ODIyMjg5ODQwNTM3Nnw5MjBjYTRmNS1kYg

Test: manually tested with atlas and pixel4a, existing unittests pass
Change-Id: I5f66f98bd70b26728b41ac6c7124cac5f5f47ca8
Fixed: b/278304107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4722646
Reviewed-by: Jon Mann <jonmann@chromium.org>
Reviewed-by: Andre Le <leandre@chromium.org>
Commit-Queue: Brittany Hartmire <bhartmire@google.com>
Cr-Commit-Position: refs/heads/main@{#1175892}
4 files changed
tree: 68058c9be21b50d10da1a13c64446cdcd6c3f79e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.