| commit | 9c77cb3a89d866c549334dee4def68aa121f4750 | [log] [tgz] |
|---|---|---|
| author | Artem Sumaneev <asumaneev@google.com> | Fri Aug 20 11:36:15 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Aug 20 11:36:15 2021 |
| tree | 692cbe858558c581ef44e7c3b35c1c2d7758601c | |
| parent | baf6566c9a2fcbcef1f0ed9712ce193f48725add [diff] |
Fix certificate upload crash on unregistered client. EnrollmentCertificateUploaderImpl checked if CloudPolicyClient is registered only on first attempt but not on retry. The client might become unregistered while uploader in retry cycle. Move is_registered check so the uploader checks the client not only on start but also on retry. Add unit tests to cover this flow. Bug: chromium:1241177 Test: unit_tests --gtest_filter="EnrollmentCertificateUploaderTest*" Change-Id: I2fcb5964dbb68972a48ce72ee323bd29378acb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107106 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/main@{#913753}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.