[//components/exo] Compute texture target to use from ClientSharedImage

exo::Buffer takes in a texture target to use and when in zero-copy mode,
passes it to a gpu::MailboxHolder that it creates. The only production
callsites that create exo::Buffer instances in zero-copy mode are at
[1] and [2] (the latter via [3][4]).

This CL changes exo::Buffer to compute the texture target from the
ClientSharedImage that was created from the passed-in GMB. This
function has identical semantics to what is currently being done, based
on the following reasoning:

* For [1], the texture target is currently being computed at [5]. This
  is exactly what ClientSharedImage::GetTextureTarget(BufferFormat)
  does.
* [2] is hardcoding the format to RGBA_8888. For RGBA_8888,
  ClientSharedImage::GetTextureTarget(BufferFormat) will always return
  GL_TEXTURE_2D on ChromeOS [6].

We leave a CHECK_EQ() for verification in going through trybots/CI. Once
this CL passes trybots/CI, we will remove exo::Buffer taking in a
texture
target altogether.

[1] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/display.cc;l=130-145;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[2] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/app_restore/arc_ghost_window_shell_surface.cc;l=41-44;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218
[3] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/buffer.cc;l=579-584;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[4] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/buffer.cc;l=518;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[5] https://source.chromium.org/chromium/chromium/src/+/main:components/exo/display.cc;l=117-120;drc=79fd5d71c46d0e6ecd842867bc1c787fae68e218;bpv=1;bpt=1
[6] https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/common/gpu_memory_buffer_support.cc;l=211-226?q=NativeBufferNeedsPlatf&ss=chromium

Bug: 41494843
Change-Id: I383fe6ae3276cdfed258693135a6974aeaa55990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5359498
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271029}
1 file changed
tree: 1872289935596a738966fc720afc6f632b7ef2ea
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.