Fix Meet flickering on macOS

As background, YUV 420 biplanar videos on macOS (basically all videos)
cannot be sampled directly in OpenGL. When we want to sample them, we do
a copy and YUV to RGB conversion.

In the compositor, we will draw either using OpenGL or using overlays.

We bracket our use with calls to Begin/EndSharedImageAccess using the
argument READ (for GL) or OVERLAY (for overlay). In the case of overlay
access, we skip the copy.

The DisplayResourceProvider will agglomerates the calls to
Begin/EndSharedImageAccess into a single pair -- so if there is already
a READ access active, and another READ access comes in, then we skip
the second call to Begin/EndSharedImageAccess.

The bug is that if we do OVERLAY access, and then want READ access, the
DisplayResourceProvider will say "oh, you already have access, I'll
skip the BeginSharedImageAccess call". Which means no copy, and
random texture contents.

To fix this, detect the case of transitioning from OVERLAY to READ
access, and do a EndSharedImageAccess followed by a new
BeginSharedImageAccess.

This is all fairly horrible. Once we move everything to the
SkiaRenderer, then we can remove the OVERLAY GL parameter and
forget that this episode ever existed.

Bug: 1113925
Change-Id: I25071324eb49c5fd3026a77c20034c9f5e647328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346843
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796730}
2 files changed
tree: e89102a98882a98347f5597a8199391dd7bfb034
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.