Google Git
Sign in
chromium / chromium / src / 9d0d2d08a8c4987ac118b566e70d71ec0b9c5ffb
commit9d0d2d08a8c4987ac118b566e70d71ec0b9c5ffb[log] [tgz]
authormanukh <manukh@chromium.org>Thu Jun 13 22:41:28 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 13 22:41:28 2024
tree86c6483719f2876f5e4594b084e395ec5466cd55
parent1f0c1796dc502e421dff85f258467a15c5bc0ad2 [diff]
[omnibox] Remove keyword DCHECKs in shortcut provider

The shortcut provider had DCHECK's to ensure all and only searches had
keywords. But keyword matches can be to URLs as well. E.g. you could
bookmark wikipedia.org, and input '@bookmarks wiki', resulting in a
keyword suggestion to a URL.

Change-Id: I1e313be6bd38e944da251706319f566e0daf83b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5629647
Reviewed-by: Jennifer Serrano <jennserrano@google.com>
Auto-Submit: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Jennifer Serrano <jennserrano@google.com>
Cr-Commit-Position: refs/heads/main@{#1314928}
1 file changed
tree: 86c6483719f2876f5e4594b084e395ec5466cd55
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.