Reland "Centralize window title layout logic into BrowserFrame" This reverts commit 14bcb83fe1cd490683c1fefa4de94ceb47535d35. Reason for revert: Fix failing test on Mac-15. Instead of using available_space we should use title_bounds instead as that is the space our toolbar will be housed in. Using the incorrect spacing returns nullptr on mac as we don't fit correctly. See diff between patchset 1 and 2 Original change's description: > Revert "Centralize window title layout logic into BrowserFrame" > > This reverts commit 75c14905dd49d888f3047c03ea54485dde03e0c2. > > Reason for revert: > LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5116756730314752 > > Sample build with failed test: https://ci.chromium.org/b/8711511335815499905 > Affected test(s): > [ninja://chrome/test:browser_tests/WebAppFrameToolbarBrowserTest.TitleHover](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FWebAppFrameToolbarBrowserTest.TitleHover?q=VHash%3A85bd161d5dec5034) > > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5116756730314752&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6651876&type=BUG > > Original change's description: > > Centralize window title layout logic into BrowserFrame > > > > The `LayoutWebAppWindowTitle` method was previously a virtual function > > on BrowserNonClientFrameView. This led to implementations being > > scattered across various platform-specific subclasses. > > > > This CL consolidates all this platform-specific logic into a single > > method, `BrowserFrame::LayoutWebAppWindowTitle`, using `BUILDFLAG`s to > > differentiate between platforms (Win, Mac, Linux, CrOS). > > > > This refactoring simplifies the `BrowserNonClientFrameView` hierarchy > > and the `BrowserViewLayoutDelegate` interface by removing the > > now-redundant virtual method. Callsites are updated to use the new > > central function. > > > > Change-Id: I1a5321d382a520b3d3b4b30fd45bd44e7cab67c6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6651876 > > Reviewed-by: Dana Fried <dfried@chromium.org> > > Commit-Queue: Darryl James <dljames@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1476703} > > > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I3301a89dce89dd626f64b81ed8e41096eff705d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6659099 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Owners-Override: Frank Liberato <liberato@google.com> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Darryl James <dljames@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1476793} Change-Id: Iedaae984e2db37a5d7de3d26e42fbd26edc72628 Fixed: 426647405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6659028 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Darryl James <dljames@chromium.org> Cr-Commit-Position: refs/heads/main@{#1477460}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.