Google Git
Sign in
chromium / chromium / src / 9dd814fdd64a9091ba58a8a46f34ff837905027e
commit9dd814fdd64a9091ba58a8a46f34ff837905027e[log] [tgz]
authorNeil Coronado <nemco@google.com>Mon Nov 18 23:36:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 18 23:36:25 2024
treee75ae6958ad7ea6442f7f7dba8d9194a4dbe195a
parent9fac7aa22e7cc8e646111632eba61a292543e6d0 [diff]
[M132][TabStrip][CrashFix] Fix NPE on reorder + DnD

Fix NPE on reorder + DnD.
-Dragging root tab out of group: Moving the first NTP would trigger this crash https://paste.googleplex.com/4834252087885824 as the group title couldn't be found, since its root ID has changed as a result of the action.
-Dragging last tab out of group: Moving the second tab would trigger this crash https://paste.googleplex.com/6657650086641664 as the group title would be deleted, meaning we wouldn't want to trigger an animation on it.

Video: https://screencast.googleplex.com/cast/NTA5NDMwMTAwMzQxNTU1MnwzOWNhNTM5Yy0wNA

(cherry picked from commit f475e9c186028a5d46d3882902b3cc8cbdf40a0c)

Bug: 379706122
Change-Id: Icab951353078df042392d620d12123a91b2c3389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6019260
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Commit-Queue: Neil Coronado <nemco@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1383092}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033594
Cr-Commit-Position: refs/branch-heads/6834@{#458}
Cr-Branched-From: 47a3549fac11ee8cb7be6606001ede605b302b9f-refs/heads/main@{#1381561}
3 files changed
tree: e75ae6958ad7ea6442f7f7dba8d9194a4dbe195a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.