Google Git
Sign in
chromium / chromium / src / 9de1ef1f289f809c39e177a6f910be1a3641f225
commit9de1ef1f289f809c39e177a6f910be1a3641f225[log] [tgz]
authorRahul Singh <rahsin@microsoft.com>Wed Jan 22 00:20:32 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 22 00:20:32 2025
treeccbfcac1df1f388e625d6cad14675fd4a74fe750
parent10d7d44f792b3d6a7af459d042a5b927094ec5a1 [diff]
FSO: Fix Linux and CrOS test flake by updating expectation

Previously, we updated the implementation to watch the parent even for
file watches. This allowed us to destruct the observation for LocalFS
when the parent goes away.
https://crrev.com/c//5941144

With that change, we started receiving events at the parent's level.
So, closing a Writeable started showing up as a single "moved" event.
Previous code adjusted that event to a "modified" in FSAWatcherManager.
So, we updated the test expectation accordingly.

Unfortunately, with inotify, we occasionally receive 2 events. A
"deleted" event for the .crswap file followed by an "appeared" event for
the observed file.

This change updates the test expectation for Linux and ChromeOS (which
rely on inotify) to prevent the flakes.

Bug: 385381220
Change-Id: I68b883b74b0382ca57bfac5fc1d7cffb02e7eb18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172825
Reviewed-by: Daseul Lee <dslee@chromium.org>
Commit-Queue: Rahul Singh <rahsin@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1409373}
1 file changed
tree: ccbfcac1df1f388e625d6cad14675fd4a74fe750
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. description
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.