Google Git
Sign in
chromium / chromium / src / 9e2affc6a15fa9c5c8fd750b41096b9f4526fc29
commit9e2affc6a15fa9c5c8fd750b41096b9f4526fc29[log] [tgz]
authorKen Buchanan <kenrb@chromium.org>Wed Dec 14 14:55:08 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 14 14:55:08 2022
treecd3308e3ae0a2f3c710bfacf7badbfbd19ec8260
parent1e06316f3a3d28f816380916e0dd68d1063de22a [diff]
[WebAuthn] Add a null check for WebContents on Android WebAuthn requests

There are crash reports indicating the WebContents associated with a
given frame is sometimes null, which is dereferenced during conditional
UI requests.

The exact conditions under which the null WebContents manifests are
unclear, but this CL adds a check to abort the request when that
occurs.

Bug: 1399887
Change-Id: I225cc4dc1e8e43872fdbc29100f8790a788db1c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4103711
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1083085}
1 file changed
tree: cd3308e3ae0a2f3c710bfacf7badbfbd19ec8260
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.