commit | 9e2c16c006d79adaac5905dc53c653cacae84870 | [log] [tgz] |
---|---|---|
author | zhoupeng <zhoupeng.1996@bytedance.com> | Wed Jun 05 03:23:21 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 05 03:23:21 2024 |
tree | ad84b1cf8d3cbb710edac86986b3a1b527c89b1f | |
parent | 8422416eaf95eeb8d4cfa47c8066c72c590c7c2a [diff] |
InSameLine should be capable of accurately handling situations that involve the inline-block node Consider this test case: <div>first line</div> this<span style="display: inline-block">i|s</span>broken <div>last line</div> Move the caret to the previous line by pressing the up button, but the caret position remains unchanged. `InSameLine` will determine whether the two positions are in the same inline formatting context. However, the span node is an inline-block node, so it is in a different inline formatting context than #text"this". As a user, the span node is located on the same line as #text"this". When the anchor node of `position` is an inline-block node, `InSameLine` should determine whether the two positions are in the same inline contents. Bug: 41497469 Change-Id: I196fecf2fb41f7126a339744f9be88e790dff164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5582749 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Peng Zhou <zhoupeng.1996@bytedance.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1310397}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.