Google Git
Sign in
chromium / chromium / src / 9e6471cbcd8905ab142a1cac1089de5029f414ba
commit9e6471cbcd8905ab142a1cac1089de5029f414ba[log] [tgz]
authorDmitry Gozman <dgozman@chromium.org>Wed Jun 13 20:23:39 2018
committerCommit Bot <commit-bot@chromium.org>Wed Jun 13 20:23:39 2018
treea4121d2812cbaf5c0287ff39f00f93cd04b03bc3
parent7ab21d83e332c7cf2c0759fd7885aab2005bda81 [diff]
FrameLoader: remove FrameLoadRequest::TriggeringEvent

The event is only used by default click handlers and form submission.
This patch replaces event with NavigationPolicy calculated
on the call sites and (unfortunately) WebEventTriggeringInfo.

Replaced one unit test with layout test which exercises real
click instead of simulating it.

Next patch will encapsulate all navigation policy logic in
navigation_policy.cc and fix a bug with form submissions ignoring
event modifiers (see issue).

TBR=haraken@chromium.org

Bug: 849055
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic64b0eec02d69e58d0dbe283abd7ee157f46f747
Reviewed-on: https://chromium-review.googlesource.com/1084323
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566969}
33 files changed
tree: a4121d2812cbaf5c0287ff39f00f93cd04b03bc3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .