Google Git
Sign in
chromium / chromium / src / 9e69502386861b427f64f841e7520c5bdb71ea3c
commit9e69502386861b427f64f841e7520c5bdb71ea3c[log] [tgz]
authorChristoph Schwering <schwering@google.com>Fri Oct 20 00:03:35 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 20 00:03:35 2023
treec35d1934d79981f687f10f142134509717360040
parentaa14884eb9f01a64e379d47145737af846a79c62 [diff]
[Autofill] Set meta data in ContentAutofillDriver::ExtractForm()

This CL adds two missing pieces of ExtractForm()'s response handling:
- setting the meta data of the right after receiving the form from
  the AutofillAgent;
- setting the version of the form right before passing the form on to
  to AutofillManager.

The first part is necessary for form flattening to work and to get
the right {Form,Field}GlobalIds, for example.

The second part is to prevent the cache downdating problem
(crbug.com/1117028). That's not strictly necessary right now because
right now the extracted form is not added to the form cache.

Bug: 1490670, 1484810
Change-Id: Ia408c5e65571429a8b10668312d6683f99386120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935685
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Dominic Battre <battre@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1212471}
3 files changed
tree: c35d1934d79981f687f10f142134509717360040
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.