commit | 9e79471652342dc4797d84a64c6818bde54a55bc | [log] [tgz] |
---|---|---|
author | Vasilii Sukhanov <vasilii@chromium.org> | Wed Jun 28 11:24:55 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 28 11:24:55 2023 |
tree | 9e18bc5dd981bb97952a5099145140c330746c6d | |
parent | a057a2e580aec0657be04df764b3d1eea754ed44 [diff] |
Add more CHECKs to exclude possibilities of empty generated password. The current CHECK in PasswordGenerationAgent::GeneratedPasswordAccepted can be hit because either - `password` parameter is incorrect or - the autofilled value somehow disappeared from the field. The additional CHECKs will help to find out the rootcause. Bug: 1454418 Change-Id: Id703c7fdadff082664408c8dda0fd1d400c00070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4650449 Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Anna Tsvirchkova <atsvirchkova@google.com> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1163488}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.